Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CDEPS component; update documentation FAQ about setting resources and turning off output; update FAQ documentation (was 1608); update drag suite intent mods (was 1612) #1597

Merged
merged 19 commits into from
Feb 22, 2023
Merged

Update CDEPS component; update documentation FAQ about setting resources and turning off output; update FAQ documentation (was 1608); update drag suite intent mods (was 1612) #1597

merged 19 commits into from
Feb 22, 2023

Conversation

binli2337
Copy link
Contributor

@binli2337 binli2337 commented Feb 3, 2023 •
edited by DeniseWorthen
Loading

Description

The NOAA-EMC/CDEPS will be updated to include recent changes from ESCOMP/CDEPS. The CDEPS component in the ufs-weather-model will be updated at the same time.

Top of commit queue on: TBD

Input data additions/changes

  • No changes are expected to input data.
  • There will be new input data.
  • Input data will be updated.

Anticipated changes to regression tests:

  • No changes are expected to any regression test.
  • Changes are expected to the following tests:

Subcomponents involved:

  • AQM
  • CDEPS
  • CICE
  • CMEPS
  • CMakeModules
  • FV3
  • GOCART
  • HYCOM
  • MOM6
  • NOAHMP
  • WW3
  • stochastic_physics
  • none

Combined with PR's (If Applicable):

Commit Queue Checklist:

  • Link PR's from all sub-components involved
  • Confirm reviews completed in sub-component PR's
  • Add all appropriate labels to this PR.
  • Run full RT suite on either Hera/Cheyenne with both Intel/GNU compilers
  • Add list of any failed regression tests to "Anticipated changes to regression tests" section.

Linked PR's and Issues:

Testing Day Checklist:

  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR.
  • Move new/updated input data on RDHPCS Hera and propagate input data changes to all supported systems.

Testing Log (for CM's):

  • RDHPCS
    • Intel
      • Hera
      • Orion
      • Jet
      • Gaea
      • Cheyenne
    • GNU
      • Hera
      • Cheyenne
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
    • Completed
  • opnReqTest
    • N/A
    • Log attached to comment

@DeniseWorthen DeniseWorthen added the No Baseline Change No Baseline Change label Feb 14, 2023
@binli2337
Copy link
Contributor Author

@jkbk2004 The "test/update_cdeps" branch has been updated.

@jkbk2004
Copy link
Collaborator

@jkbk2004 The "test/update_cdeps" branch has been updated.

Thanks, @binli2337 We are considering to combine this pr with #1612 and #1608. We are trying to make a progress on #1529 today. I will keep you posted.

@jkbk2004 jkbk2004 mentioned this pull request Feb 16, 2023
Closed
37 tasks
@jkbk2004
Copy link
Collaborator

@binli2337 It's likely we will merge in #1529 this afternoon. After the merge, can we coordinate to combine in #1608 and #1612 to this pr?

@jkbk2004
Copy link
Collaborator

@binli2337 we just merged #1529. As noted before, we will try to combine in #1608 and #1612 to this pr. #1608 is doc update. So @DeniseWorthen will create a direct pr to your branch. For #1612, you can point to the fv3 branch.

binli2337 and others added 3 commits February 18, 2023 18:41
@binli2337
Merge branch 'develop' into test/update_cdeps
5ed9258
@binli2337
use fv3atm from PR 1612
22c36a9
@DeniseWorthen
Docs/faqupdate (#8)
40f3168 
* update FAQ about setting resources

* add mom6 settings, add more specific component info

* remove reference to nemsio in FAQ

* add section to FAQ about turning off I/O

* clarify FV3 IO settings

* clarify FV3 IO output options
@jkbk2004 jkbk2004 added Waiting for Reviews The PR is waiting for reviews from associated component PR's. Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. labels Feb 20, 2023
@jkbk2004 jkbk2004 added hera-intel-RT jenkins-ci Jenkins CI: ORT build/test on docker container labels Feb 20, 2023
epic-cicd-jenkins and others added 4 commits February 20, 2023 18:03
@epic-cicd-jenkins
[AutoRT] cheyenne.intel Job Completed.
93e5500 
on-behalf-of @ufs-community <ecc.platform@noaa.gov>
@jkbk2004
[AutoRT] orion.intel Job Completed.
85bddd9 
on-behalf-of @ufs-community <brian.curtis@noaa.gov>
@jkbk2004
[AutoRT] hera.intel Job Completed.
d2fff32 
on-behalf-of @ufs-community <jong.kim@noaa.gov>
@epic-cicd-jenkins
[AutoRT] jet.intel Job Completed.
7f62780 
on-behalf-of @ufs-community <ecc.platform@noaa.gov>
@epic-cicd-jenkins
[AutoRT] gaea.intel Job Completed.
dd24358 
on-behalf-of @ufs-community <ecc.platform@noaa.gov>
@jkbk2004
Copy link
Collaborator

Automated RT Failure Notification
Machine: hera
Compiler: gnu
Job: RT
[RT] Repo location: /scratch1/NCEPDEV/nems/emc.nemspara/autort/pr/1228090127/20230221024514/ufs-weather-model
[RT] Error: Test cpld_control_p8 046 failed in run_test failed
Please make changes and add the following label back: hera-gnu-RT

@jkbk2004
Copy link
Collaborator

hera gnu issue was srun time out problem.

@DeniseWorthen DeniseWorthen mentioned this pull request Feb 21, 2023
Closed
37 tasks
@DeniseWorthen DeniseWorthen changed the title Update CDEPS component Update CDEPS component; update documentation FAQ about setting resources and turning off output; update FAQ documentation (was 1608); update drag suite intent mods (was 1612) Feb 21, 2023
@zach1221
Copy link
Collaborator

Please see Jenkins-ci logs attached. All tests passed.
ufs-weather-model » ort-docker-pipeline » PR-1597 #1 Console [Jenkins].pdf

@jkbk2004
Copy link
Collaborator

All tests are done successfully. We can start merging process.

This was referenced Feb 21, 2023
Merged
Merged
@jkbk2004
Copy link
Collaborator

@binli2337 fv3 pr was merged. new hash is NOAA-EMC/fv3atm@d9e619e

can you update the submodule pointer and revert changes in gitmodules?

@jkbk2004 jkbk2004 self-requested a review February 22, 2023 21:09
@jkbk2004 jkbk2004 merged commit a863389 into ufs-community:develop Feb 22, 2023
@JustinPerket JustinPerket mentioned this pull request Feb 24, 2023
Merged
37 tasks
dustinswales pushed a commit to dustinswales/ufs-weather-model that referenced this pull request Mar 2, 2023
@binli2337 @DeniseWorthen
@jkbk2004 @BrianCurtis-NOAA
Update CDEPS component; update documentation FAQ about setting resour…
bdd76cc 
…ces and turning off output; update FAQ documentation (was 1608); update drag suite intent mods (was 1612) (ufs-community#1597)

* update cdeps

* use fv3atm from PR 1612

* Changed UGWP diagnostic variable declaration intents from out to inout

* Docs/faqupdate (ufs-community#8)

Co-authored-by: Denise Worthen <denise.worthen@noaa.gov>
Co-authored-by: jkbk2004 <jong.kim@noaa.gov>
Co-authored-by: Brian Curtis <brian.curtis@noaa.gov>
@binli2337 binli2337 deleted the test/update_cdeps branch March 9, 2023 14:54
@dustinswales dustinswales mentioned this pull request Mar 20, 2023
Merged
@grantfirl grantfirl mentioned this pull request Mar 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DusanJovic-NOAA DusanJovic-NOAA DusanJovic-NOAA approved these changes

@jkbk2004 jkbk2004 jkbk2004 approved these changes

@ChunxiZhang-NOAA ChunxiZhang-NOAA Awaiting requested review from ChunxiZhang-NOAA

Assignees
No one assigned
Labels
jenkins-ci Jenkins CI: ORT build/test on docker container No Baseline Change No Baseline Change Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. Waiting for Reviews The PR is waiting for reviews from associated component PR's.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update CDEPS component
8 participants
@binli2337 @jkbk2004 @zach1221 @DusanJovic-NOAA @DeniseWorthen @support-epic @epic-cicd-jenkins @BrianCurtis-NOAA